Conversation
This extends the script to accept `UUID.local` hostnames for local-mode devices, in addition to the `UUID.balena` hostnames already accepted for remote devices. If the `.local` suffix is detected, the proxy is disabled and a direct connection is established instead.
|
Thanks the contribution! 👍 Would you mind updating the README file as well? Passages such as:
|
| # abbreviated UUIDs are also accepted for local-mode devices. | ||
| if [[ "${SSUU_SCP}" = 0 && | ||
| "${arg}" =~ ^(ssh://)?((.+)@)?([[:xdigit:]]{32}|[[:xdigit:]]{62})\.balena(:[0-9]+)?$ | ||
| "${arg}" =~ ^(ssh://)?((.+)@)?([[:xdigit:]]{7}|[[:xdigit:]]{32}|[[:xdigit:]]{62})\.(balena|local)(:[0-9]+)?$ |
There was a problem hiding this comment.
In a previous comment, I asked you to update the README file to clarify that 7-character UUIDs can be used with .local hostnames. However, hang on — I’ve thought of something. For a remote device reachable through the Balena cloud proxy server, the UUID has a special meaning as the identifier of the device in the cloud. Therefore, a regex ensuring a hexadecimal string of a certain length makes sense. However, for a .local hostname like abc1234.local (7-char UUID), the UUID is merely the device’s hostname discoverable through mDNS / Ahavi and configurable through the device’s config.json file. In this case, abc1234.local (7-char hex) is just as good as foo.local (if config.json specified "hostname": "foo"), and a regex requiring a 7-char hex string would be unnecessarily restrictive.
Does that make sense? So the code could / should be changed to simply check for a .local hostname suffix, in which case any string should be allowed as the hostname prefix. Then the README could be updated along the following lines:
Before:
The device's ssh/scp hostname has the format
'<device-UUID>.balena', using the device's
-full UUID (not a shortened form).
After:
The device’s ssh/scp hostname should have one of the following formats:
'<device-UUID>.balena'- Remote devices reachable through Balena’s cloud proxy server.'<hostname>.local'- Devices on the same local network as the client.For remote devices,
<device-UUID>must be the device’s “full” UUID (32 or 62 characters long). For local devices,<hostname>is the device’s hostname configured in its config.json file — by default, it is the device’s 7-character short UUID.
There was a problem hiding this comment.
Also, in this PR’s initial approach, abc1234.balena would not fail the regex check, but it should fail the regex check in order to alert the user of a hostname problem.
There was a problem hiding this comment.
Sure thing! That sounds like a very reasonable approach.
2 participants
This extends the script to accept
UUID.localhostnames for local-mode devices, in addition to theUUID.balenahostnames already accepted for remote devices. If the.localsuffix is detected, the proxy is disabled and a direct connection is established instead.