Fix #438, add a deactivation option through CMake#543
Closed
Fix #438, add a deactivation option through CMake#543
Conversation
Member
|
Warning you're updating the tutorial. This is unrelated |
benoitmartin88
requested changes
Feb 24, 2025
Member
benoitmartin88
left a comment
There was a problem hiding this comment.
I think this PR is almost ready for merge. Just a few changes are needed.
Contributor
Author
The tutorial previously used broke the CI. |
Contributor
Author
Changing back to tutorial @ 7334107. |
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
jbigot
reviewed
Feb 26, 2025
a1d6fd8 to
a2da9b2
Compare
Yushan-Wang
previously approved these changes
Dec 5, 2025
jbigot
reviewed
Dec 15, 2025
237f3ae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing the case where paraconf is missing.
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.