fix #514, call_data_callbacks after shared the data by jmorice91 · Pull Request #548 · pdidev/pdi

jmorice91 · 2025-03-02T21:48:10Z

!!!INSERT YOUR DESCRIPTION HERE!!!

List of things to check before making a PR

Before merging your code, please check the following:

benoitmartin88

Great feature to add. Thanks !
Not much is needed to merge this PR.
I think this feature would require a unit test. Could you add this?

benoitmartin88

Almost ready to merge.
I do have a few questions that need answering concerning error handling, potentially superfluous functions and writing tests in C++.

benoitmartin88

I think this is almost ready to merge.
Could you make sure the indent and spacing of the modified files is correct ?
Thanks !

jmorice91 · 2025-06-04T09:12:47Z

I think this is almost ready to merge. Could you make sure the indent and spacing of the modified files is correct ? Thanks !

Is it normal that the action indent doesn't catch that?

Yushan-Wang

Ready to merge

Yushan-Wang · 2025-07-16T13:14:25Z

@jbigot Could you review this PR please?

jbigot

This is a great submission! My main comment is about moving Var_to_reclaim of the provider side instead of expecting each user to implement it. Overall this is really nice though!

jbigot · 2025-10-28T15:13:29Z

What's the status for this one?

Yushan-Wang

Looks good to me!
However, I have difficulties understanding the test.
Could you please add a test with hdf5, where the name of the file is a variable?
Before, we had to expose first the filename_size, then the filename. With your change, the order of the expose is then irrelevant.
Or exposing a vector who's size is also a variable?

jbigot · 2026-04-15T11:11:41Z

For Multiple_error, you could base your work on top of https://github.com/pdidev/pdi/tree/improved_errmsg
I'm waiting for the formatting & renaming of errors to be merged before I make a PR

Also simplified error code Fix #657

add Delayed_data_callbacks class remove cout Adding some test how work delayed_data_callbacks class fix comment fix indent and word

JAuriac · 2026-04-30T08:15:28Z

+	std::vector<std::string> m_datanames;
+
+	/// The context where the list of data is a part of
+	Global_context& m_context;


Maybe shouldn't use a Global_context directly, and should remove the direct include to global_context.h, to go through Context instead with virtuals

Good catch. We must not use Global_context directly. This variables is not defined in the "pdi/include"
We have three options:

Use instead the class Context as you propose (implemented and tested but not commited yet).

Do a virtual class Delayed_data_callbacks and put the implementation in the src as Data_descriptor
and use Global_context in implementation

Do a virtual class Delayed_data_callbacks and put the implementation in the src as Data_descriptor
and use Context in the implementation

JAuriac · 2026-04-30T09:19:56Z

+void Delayed_data_callbacks::add_dataname(const std::string& name)
+{
+	// Comment: In case of a multi_expose, if the data is defined twice then the callback "on_data" are called twice also in PDI v1.10
+	//         Therefore, we need to add the name to have the same behaviour.


What is the "same behaviour" here ? We need this emplace_back to reproduce the behaviour where we overwrite the data definition that is already available ?

If you call this function,

PDI_multi_expose("my_test", "pdi_var1", &var1, PDI_OUT, "pdi_var1", &var1, PDI_OUT, NULL);

The callback on data "pdi_var1" is called two times in pdi v1.10.
For example, if the callback corresponds to the user_code function my_func, we call two times the function my_func.

JAuriac · 2026-05-06T14:14:33Z

+
+	m_datanames.clear();
+
+	rethrow_with_context(trigger_data_errors, "`{}' error(s) while triggering data callbacks, ", number_of_elements);


This may actually represent trigger_data_errors.size() (is it intentional ?), as if we have 3 triggers and only 1 throws, we get a report of 3 errors

Here, number_of_elements correspond to trigger_data_errors.size().

JAuriac · 2026-05-06T14:16:21Z

+			// An exception is throwing before. Print simple message to avoid std::terminate.
+			m_context.logger().error("Error in the destructor of Delayed_data_callbacks, {}", e.what());
+		} else {
+			m_context.logger().info("{}", "Error in the destructor of Delayed_data_callbacks");


Could use e.what() in the logger info branch ?

If I do that, in the final message, I have two times e.what()

JAuriac · 2026-05-06T14:33:52Z

+	const int var1 = 3;
+	const int var2 = 11;
+
+	PDI_multi_expose("my_test", "pdi_var1", &var1, PDI_OUT, "pdi_var1", &var2, PDI_OUT, NULL);


Is writing over const variables intended here (technically ok because not constexpr) ?

Yes, indeed I need to remove the const here.

jmorice91 linked an issue Mar 2, 2025 that may be closed by this pull request

Delay data events in multi_expose to when the last data is exposed #514

Open

jmorice91 marked this pull request as draft March 2, 2025 21:48

jmorice91 requested review from Yushan-Wang, benoitmartin88 and jbigot March 2, 2025 22:26

jmorice91 marked this pull request as ready for review March 13, 2025 21:43

jmorice91 self-assigned this Mar 13, 2025

benoitmartin88 requested changes Mar 20, 2025

View reviewed changes

jmorice91 marked this pull request as draft April 4, 2025 08:43

jmorice91 force-pushed the 514-delay-data-events-in-multi_expose branch from 656e28b to 3e1d45f Compare April 4, 2025 09:23

jmorice91 requested a review from JAuriac April 9, 2025 13:27

jmorice91 marked this pull request as ready for review April 9, 2025 13:27

jmorice91 requested a review from benoitmartin88 April 10, 2025 13:32

benoitmartin88 requested changes Apr 14, 2025

View reviewed changes

Comment thread pdi/src/data_descriptor_impl.cxx Outdated

Comment thread pdi/src/data_descriptor_impl.h Outdated

Comment thread pdi/src/pdi.cxx Outdated

Comment thread tests/test_06_user_code_multi_expose.cxx

jmorice91 marked this pull request as draft May 12, 2025 09:07

jmorice91 force-pushed the 514-delay-data-events-in-multi_expose branch from f542e39 to 6806742 Compare May 12, 2025 09:18

jmorice91 requested a review from benoitmartin88 May 12, 2025 09:45

jmorice91 marked this pull request as ready for review May 12, 2025 09:46

benoitmartin88 requested changes Jun 4, 2025

View reviewed changes

Comment thread pdi/src/data_descriptor_impl.cxx Outdated

Comment thread pdi/src/data_descriptor_impl.cxx Outdated

Yushan-Wang previously approved these changes Jun 4, 2025

View reviewed changes

jmorice91 dismissed Yushan-Wang’s stale review via 55dd1c6 June 4, 2025 09:15

Yushan-Wang approved these changes Jun 4, 2025

View reviewed changes

jmorice91 requested a review from benoitmartin88 June 5, 2025 10:12

Yushan-Wang approved these changes Jun 19, 2025

View reviewed changes

jbigot requested changes Sep 3, 2025

View reviewed changes

Comment thread pdi/include/pdi/data_descriptor.h Outdated

Comment thread pdi/include/pdi/data_descriptor.h Outdated

Comment thread pdi/src/pdi.cxx Outdated

Yushan-Wang previously approved these changes Sep 12, 2025

View reviewed changes

jmorice91 dismissed Yushan-Wang’s stale review via 18f09bd October 6, 2025 07:54

jmorice91 force-pushed the 514-delay-data-events-in-multi_expose branch from c7b95b9 to b433600 Compare March 31, 2026 09:16

jmorice91 marked this pull request as ready for review March 31, 2026 10:40

jmorice91 requested review from Yushan-Wang and jbigot March 31, 2026 10:40

Yushan-Wang reviewed Mar 31, 2026

View reviewed changes

Comment thread pdi/src/data_descriptor_impl.cxx Outdated

Yushan-Wang reviewed Mar 31, 2026

View reviewed changes

Comment thread pdi/src/data_descriptor_impl.cxx

Yushan-Wang reviewed Mar 31, 2026

View reviewed changes

Comment thread pdi/src/pdi.cxx

JAuriac reviewed Apr 7, 2026

View reviewed changes

Comment thread pdi/include/pdi/pdi_fwd.h Outdated

Comment thread pdi/src/delayed_data_callbacks.cxx Outdated

Comment thread pdi/src/pdi.cxx Outdated

Comment thread pdi/tests/PDI_callbacks.cxx Outdated

Comment thread pdi/tests/PDI_callbacks.cxx Outdated

jmorice91 marked this pull request as draft April 8, 2026 14:46

jmorice91 marked this pull request as ready for review April 9, 2026 11:59

Yushan-Wang reviewed Apr 9, 2026

View reviewed changes

jbigot requested changes Apr 15, 2026

View reviewed changes

jmorice91 marked this pull request as draft April 16, 2026 07:22

Improved error messages for configuration errors

9e47be7

Also simplified error code Fix #657

jbigot force-pushed the main branch 7 times, most recently from 41fed24 to b9ebda1 Compare April 24, 2026 09:13

first commit multi_expose delay

6751514

add Delayed_data_callbacks class remove cout Adding some test how work delayed_data_callbacks class fix comment fix indent and word

jmorice91 force-pushed the 514-delay-data-events-in-multi_expose branch from 0307623 to 6751514 Compare April 27, 2026 09:50

jmorice91 added 2 commits April 27, 2026 16:01

tests good

afb634c

update to the testing framework

4f798c7

jbigot marked this pull request as ready for review April 28, 2026 13:16

JAuriac reviewed Apr 30, 2026

View reviewed changes

fix remarks

64ae662

JAuriac reviewed May 6, 2026

View reviewed changes


		m_datanames.clear();

		rethrow_with_context(trigger_data_errors, "`{}' error(s) while triggering data callbacks, ", number_of_elements);

Conversation

jmorice91 commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List of things to check before making a PR

Uh oh!

benoitmartin88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benoitmartin88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benoitmartin88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jmorice91 commented Jun 4, 2025

Uh oh!

Yushan-Wang left a comment

Choose a reason for hiding this comment

Uh oh!

Yushan-Wang commented Jul 16, 2025

Uh oh!

jbigot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbigot commented Oct 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yushan-Wang left a comment

Choose a reason for hiding this comment

Uh oh!

jbigot commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

JAuriac Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

jmorice91 commented Mar 2, 2025 •

edited

Loading

JAuriac Apr 30, 2026 •

edited

Loading