Conversation
|
Depends on an update of : |
|
@JAuriac Could you take a look at pdidev/test_env#24 ? |
|
Also, tests are failing on macos-26. @Yushan-Wang Any ideas ? |
What I found: |
|
@Yushan-Wang I think the error is due to something else. I just had a talk with @tpadioleau, and he has a bug on mac os on the same tests. We believe that the test is bugged. The test allocates a |
|
For ubuntu/jammy, we are waiting for pdidev/test_env#25 |
Changed the |
jbigot
left a comment
There was a problem hiding this comment.
The PR should change the minimum versions in all cmake files & in spack.yaml at the root, ensure that the workarounds in build_and_run_all_tests for older versions are removed and document that in both the changelogs and in doxygen.
| * Update OS used by the CI, to keep oldest non-EOL Linux and MacOS. | ||
| [#613](https://github.com/pdidev/pdi/issues/613) |
There was a problem hiding this comment.
Please list the impact for users as done in previous situations: list all minimum version changes in the changelog of each subproject.
There was a problem hiding this comment.
Changed from :
CMake 3.16, NetCDF 4.7, Python 3.8, mpi4py 3.0, numpy 1.17, pybind11 2.4
toward :
CMake 3.22, NetCDF 4.9, Python 3.10, mpi4py 3.1, numpy 1.21, pybind11 2.10
to account for oldest non-EOL Ubuntu
benoitmartin88
left a comment
There was a problem hiding this comment.
Unrelated changes should be in a separate PR and solve an identified issue.
Dedicated PR with #628. |
|
Depends on #630 to pass the "pages" CI. |
Check for cmake_minimum_required through the CI, and mention this in CHANGELOG.md Fix MacOS test_deflate to handle both MacOS-15 (and lesser) and MacOS-26 Update requirements for core; To Do: Update requirement for vendors
46f1c7f to
0df712e
Compare
|
Replaced by #637 |
Update OS used by the CI, to keep oldest non-EOL Linux and MacOS.
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.