Open
Conversation
vvohh
force-pushed
the
fix/imagine-error
branch
from
289a2ef to
944854d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix a runtime exception when a broken image is loaded.
Background: In our current project the facebook api sometimes returns an image of 0 byte. When the social feed is show in the frontend, the complete page is broken due an Runtime Exception. This PR catch the exception, so the page still works even when there is a broken image.
Maybe we will further investigate why the api is returning a broken image and add an additional fix, but for now this fix the issue.
Tested on contao 5.3 and php 8.3.
Based on current main branch.