-
Notifications
You must be signed in to change notification settings - Fork 5
ADDED configurable timeout for boto3 client #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. Added some questions
Also, you might want to release (Github Release) after updating RC compatible version here which will trigger the github action to test it out
@azhar22k I've updated the version number etc, did we want to merge this then create the Github release, or create a release candidate from this branch first? |
FIne either way. I would say first do an alpha release (will need to update version with match python semver first) from this branch, test it out, then make a major release from master. But it is a small change and you would have already tested locally so not much issue I think 😁 |
Co-authored-by: Vishnu Agarwal <vishnu.agarwal@peak.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments
Co-authored-by: Vishnu Agarwal <vishnu.agarwal@peak.ai>
Co-authored-by: Vishnu Agarwal <vishnu.agarwal@peak.ai>
Co-authored-by: Vishnu Agarwal <vishnu.agarwal@peak.ai>
Description
Description of what this PR does. What have you added or changed, and why? If it fixes a bug or resolves a feature request, be sure to link to that issue.
Review Checks
Please check if the PR fulfills these requirements:
Put an
x
in the boxes that apply, Remove any lines that do not applyDependencies
Add links to any pull requests or documentation related to this pull request.
YOUR LINK HERE
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Security Considerations
Are there any other security or data concerns to be aware of?
Please discuss the security implications/considerations relevant to the proposed change.
This may include...
No specific security concerns, minor change to existing API.
Types of change
What kind of change does this Pull Request introduce?
Put an
x
in the boxes that applyIf "Other" please specify
YOUR TEXT HERE
Testing
Please include steps that the reviewer can follow in order to test the changes
$ python example.py
, ensure it still works as expected.$ python example.py
again, but with an invalid location, ensure it's handled gracefully.$ BOTO_READ_TIMEOUT=0.001 BOTO_MAX_ATTEMPTS=1 python examples.py
- should timeout immediately.Other information
Please add any other information that would be useful for the reviewer.