Skip to content

Conversation

EwanValentine
Copy link
Contributor

Description

Description of what this PR does. What have you added or changed, and why? If it fixes a bug or resolves a feature request, be sure to link to that issue.

  • ADDED experimental register/update/deregister integration
  • ADDED add service and add namespace methods

Review Checks

Please check if the PR fulfills these requirements:

Put an x in the boxes that apply, Remove any lines that do not apply

  • 📝 The commit message is clear and descriptive
  • 🔐 The Security Considerations section in the PR description is complete - Please do not remove this
  • ✅ Tests for the changes have been added and run successfully including the new changes
  • 📄 Documentation has been added / updated (for bug fixes / features)

Dependencies

Add links to any pull requests or documentation related to this pull request.

YOUR LINK HERE

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Yes

Security Considerations

Are there any other security or data concerns to be aware of?

Please discuss the security implications/considerations relevant to the proposed change.
This may include...

  • security-relevant design decisions
  • concerns
  • important discussions
  • implementation-specific guidance and pitfalls
  • an outline of threats and risks and how they are being addressed.

YOUR TEXT HERE

Types of change

What kind of change does this Pull Request introduce?
Put an x in the boxes that apply

  • 🐛 Bugfix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Adding or updating configuration files, development scripts etc.
  • ♻️ Refactoring (no functional changes, no api changes)
  • 🧹 Chore (removing redunant files, fixing typos etc.)
  • 📄 Documentation Update
  • ❓ Other (if none of the other choices apply)

If "Other" please specify

YOUR TEXT HERE

Testing

Please include steps that the reviewer can follow in order to test the changes

  1. Run $ cd example
  2. Run $ python ./discovery_test.py
  3. Verify the methods execute successfully

Other information

Please add any other information that would be useful for the reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant