Skip to content

fix: prevent task detail crash on malformed output fields #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimavedenyapin merged 1 commit into from
Apr 23, 2026
Merged

fix: prevent task detail crash on malformed output fields #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/renderer/src/components/tasks/OutputFieldsDisplay.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,24 @@ describe('OutputFieldsDisplay', () => {

expect(screen.getByText('Complete Task')).toBeInTheDocument()
})

it('renders malformed legacy output fields without crashing', () => {
render(
<OutputFieldsDisplay
fields={[
{
id: 'pr_url',
type: undefined as never,
name: undefined as never,
value: 'https://example.com/pr/123'
}
]}
onChange={vi.fn()}
/>
)

expect(screen.getByDisplayValue('https://example.com/pr/123')).toBeInTheDocument()
expect(screen.getByText('pr url')).toBeInTheDocument()
expect(screen.getByPlaceholderText('Enter pr url...')).toBeInTheDocument()
})
})
31 changes: 19 additions & 12 deletions src/renderer/src/components/tasks/OutputFieldsDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ import { Label } from '@/components/ui/Label'
import { shellApi } from '@/lib/ipc-client'
import type { OutputField } from '@/types'

function getFieldLabel(field: OutputField): string {
if (typeof field.name === 'string' && field.name.trim()) return field.name
if (typeof field.id === 'string' && field.id.trim()) return field.id.replace(/_/g, ' ')
return 'Output'
}

function isFieldFilled(field: OutputField): boolean {
const v = field.value
if (v === null || v === undefined) return false
Expand Down Expand Up @@ -68,6 +74,7 @@ export function OutputFieldsDisplay({ fields, onChange, isActive, onComplete, ta

function OutputFieldInput({ field, onValueChange, taskUpdatedAt }: { field: OutputField; onValueChange: (value: unknown) => void; taskUpdatedAt?: string }) {
const [localValue, setLocalValue] = useState<string>(String(field.value ?? ''))
const fieldLabel = getFieldLabel(field)

// Sync local state when field.value changes externally (e.g. agent extraction)
useEffect(() => {
Expand All @@ -84,13 +91,13 @@ function OutputFieldInput({ field, onValueChange, taskUpdatedAt }: { field: Outp
return (
<div className="space-y-1.5">
<Label className="text-xs">
{field.name}
{fieldLabel}
{field.required && <span className="text-destructive ml-0.5">*</span>}
</Label>
<Textarea
value={localValue}
onChange={(e) => handleChange(e.target.value)}
placeholder={`Enter ${field.name.toLowerCase()}...`}
placeholder={`Enter ${fieldLabel.toLowerCase()}...`}
rows={3}
/>
</div>
Expand All @@ -104,7 +111,7 @@ function OutputFieldInput({ field, onValueChange, taskUpdatedAt }: { field: Outp
onCheckedChange={(checked) => onValueChange(!!checked)}
/>
<Label className="text-xs">
{field.name}
{fieldLabel}
{field.required && <span className="text-destructive ml-0.5">*</span>}
</Label>
</div>
Expand All @@ -114,23 +121,23 @@ function OutputFieldInput({ field, onValueChange, taskUpdatedAt }: { field: Outp
return (
<div className="space-y-1.5">
<Label className="text-xs">
{field.name}
{fieldLabel}
{field.required && <span className="text-destructive ml-0.5">*</span>}
</Label>
{field.options && field.options.length > 0 ? (
<Select
value={String(field.value ?? '')}
onChange={(e) => onValueChange(e.target.value)}
options={[
{ value: '', label: `Select ${field.name.toLowerCase()}...` },
{ value: '', label: `Select ${fieldLabel.toLowerCase()}...` },
...field.options.map((opt) => ({ value: opt, label: opt }))
]}
/>
) : (
<Input
value={localValue}
onChange={(e) => handleChange(e.target.value)}
placeholder={`Enter ${field.name.toLowerCase()}...`}
placeholder={`Enter ${fieldLabel.toLowerCase()}...`}
/>
)}
</div>
Expand All @@ -143,7 +150,7 @@ function OutputFieldInput({ field, onValueChange, taskUpdatedAt }: { field: Outp
return (
<div className="space-y-1.5">
<Label className="text-xs">
{field.name}
{fieldLabel}
{field.required && <span className="text-destructive ml-0.5">*</span>}
</Label>
{filePaths.length > 0 ? (
Expand All @@ -165,14 +172,14 @@ function OutputFieldInput({ field, onValueChange, taskUpdatedAt }: { field: Outp
return (
<div className="space-y-1.5">
<Label className="text-xs">
{field.name}
{fieldLabel}
{field.required && <span className="text-destructive ml-0.5">*</span>}
</Label>
<Input
type="number"
value={localValue}
onChange={(e) => handleChange(e.target.value)}
placeholder={`Enter ${field.name.toLowerCase()}...`}
placeholder={`Enter ${fieldLabel.toLowerCase()}...`}
/>
</div>
)
Expand All @@ -181,7 +188,7 @@ function OutputFieldInput({ field, onValueChange, taskUpdatedAt }: { field: Outp
return (
<div className="space-y-1.5">
<Label className="text-xs">
{field.name}
{fieldLabel}
{field.required && <span className="text-destructive ml-0.5">*</span>}
</Label>
<Input
Expand All @@ -197,14 +204,14 @@ function OutputFieldInput({ field, onValueChange, taskUpdatedAt }: { field: Outp
return (
<div className="space-y-1.5">
<Label className="text-xs">
{field.name}
{fieldLabel}
{field.required && <span className="text-destructive ml-0.5">*</span>}
</Label>
<Input
type={field.type === 'email' ? 'email' : field.type === 'url' ? 'url' : 'text'}
value={localValue}
onChange={(e) => handleChange(e.target.value)}
placeholder={`Enter ${field.name.toLowerCase()}...`}
placeholder={`Enter ${fieldLabel.toLowerCase()}...`}
/>
</div>
)
Expand Down
31 changes: 30 additions & 1 deletion src/renderer/src/stores/task-store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,37 @@ describe('useTaskStore', () => {
expect(task.skill_ids).toEqual(['s1', 's2'])
})

it('sanitizes malformed output fields from external task updates', async () => {
const taskWithMalformedOutputs = {
id: 't3',
title: 'Agent-updated task',
output_fields: [
{ id: 'pr_url', value: 'https://example.com/pr/123' },
{ name: 'Approval', type: 'toggle', value: true, options: ['yes', 1, null] }
]
}
;(mockElectronAPI.db.getTasks as unknown as Mock).mockResolvedValue([taskWithMalformedOutputs])

await useTaskStore.getState().fetchTasks()

const [firstField, secondField] = useTaskStore.getState().tasks[0].output_fields
expect(firstField).toMatchObject({
id: 'pr_url',
name: 'pr url',
type: 'text',
value: 'https://example.com/pr/123'
})
expect(secondField).toMatchObject({
id: 'output_field_2',
name: 'Approval',
type: 'text',
value: true,
options: ['yes']
})
})

it('preserves skill_ids null (agent defaults)', async () => {
const taskWithNullSkills = { id: 't3', title: 'Task', skill_ids: null }
const taskWithNullSkills = { id: 't4', title: 'Task', skill_ids: null }
;(mockElectronAPI.db.getTasks as unknown as Mock).mockResolvedValue([taskWithNullSkills])

await useTaskStore.getState().fetchTasks()
Expand Down
40 changes: 38 additions & 2 deletions src/renderer/src/stores/task-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,51 @@
import { create } from 'zustand'
import type { WorkfloTask, CreateTaskDTO, UpdateTaskDTO } from '@/types'
import type { WorkfloTask, CreateTaskDTO, UpdateTaskDTO, OutputField, OutputFieldType } from '@/types'
import { taskApi, taskSourceApi, onTaskUpdated, onTaskCreated, onTasksRefresh } from '@/lib/ipc-client'

const VALID_OUTPUT_FIELD_TYPES = new Set<OutputFieldType>([
'text',
'number',
'email',
'textarea',
'list',
'date',
'file',
'boolean',
'country',
'currency',
'url'
])

function normalizeOutputField(field: unknown, index: number): OutputField | null {
if (!field || typeof field !== 'object') return null

const raw = field as Partial<OutputField>
const id = typeof raw.id === 'string' && raw.id.trim() ? raw.id : `output_field_${index + 1}`
const name = typeof raw.name === 'string' && raw.name.trim() ? raw.name : id.replace(/_/g, ' ')
const rawType = typeof raw.type === 'string' ? raw.type : ''
const type = VALID_OUTPUT_FIELD_TYPES.has(rawType as OutputFieldType) ? (rawType as OutputFieldType) : 'text'

return {
...raw,
id,
name,
type,
options: Array.isArray(raw.options) ? raw.options.filter((option): option is string => typeof option === 'string') : undefined
}
}

/** Ensure array fields on a task are always proper arrays (guards against undefined/null from external sources) */
function normalizeTask(task: WorkfloTask): WorkfloTask {
return {
...task,
labels: Array.isArray(task.labels) ? task.labels : [],
repos: Array.isArray(task.repos) ? task.repos : [],
attachments: Array.isArray(task.attachments) ? task.attachments : [],
output_fields: Array.isArray(task.output_fields) ? task.output_fields : [],
output_fields: Array.isArray(task.output_fields)
? task.output_fields
.map((field, index) => normalizeOutputField(field, index))
.filter((field): field is OutputField => field !== null)
: [],
skill_ids: task.skill_ids == null ? null : Array.isArray(task.skill_ids) ? task.skill_ids : []
}
}
Expand Down
Loading