Skip to content

[TASK-18593] Setup Bugs#1716

Merged
jjramirezn merged 3 commits intodevfrom
fix/setup-bugs
Mar 7, 2026
Merged

[TASK-18593] Setup Bugs#1716
jjramirezn merged 3 commits intodevfrom
fix/setup-bugs

Conversation

@jjramirezn
Copy link
Contributor

No description provided.

1. Install screen: Replace tech-speak fallback with user-friendly copy
2. Waitlist notification: Add 'Not now' skip so users without invite codes
   don't get stuck on 'Enable Notifications' forever
3. PWA install loop: Remove target=_blank /setup link that causes redirect
   loop between browser and PWA; show instruction to open from Home Screen
   with fallback 'Continue here instead' button
@vercel
Copy link

vercel bot commented Mar 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
peanut-wallet Ready Ready Preview, Comment Mar 7, 2026 4:35am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e6674f94-d609-4b11-8ca4-e62f0a018439

📥 Commits

Reviewing files that changed from the base of the PR and between 5413e9d and 5a472c2.

📒 Files selected for processing (1)
  • src/components/Invites/JoinWaitlistPage.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/Invites/JoinWaitlistPage.tsx

Walkthrough

Adds a "Not now" skip state to JoinWaitlistPage to show main content after a user skips notification permission; updates Android PWA install fallback UI in InstallPWA to show manual-install instructions and adjusts spacing.

Changes

Cohort / File(s) Summary
Notification Permission Handling
src/components/Invites/JoinWaitlistPage.tsx
Adds local notificationSkipped state and a "Not now" control. Adjusts conditional rendering so the permission prompt shows only when isPermissionGranted is false and notificationSkipped is false; main content displays if permission is granted or skipped.
PWA Installation UI
src/components/Setup/Views/InstallPWA.tsx
Updates AndroidPWASpecificInstallFlow fallback to present manual-install instructions (single paragraph), increases container spacing from space-y-2 to space-y-4, and removes extra top margin from the continue button while using a full-width layout.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the bugs being fixed and why the changes to notification prompts and PWA installation messaging are necessary.
Title check ❓ Inconclusive The title 'Setup Bugs' is vague and generic, lacking specificity about which bugs are being fixed or what the actual changes accomplish. Use a more descriptive title that specifies the bug fixes, such as 'Fix notification permission flow in JoinWaitlistPage' or 'Fix PWA installation messaging'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/setup-bugs

Comment @coderabbitai help to get the list of available commands and usage tips.

@jjramirezn jjramirezn merged commit 30cb9fb into dev Mar 7, 2026
5 checks passed
@jjramirezn jjramirezn changed the title Setup Bugs [TASK-18593] Setup Bugs Mar 7, 2026
@notion-workspace
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant