-
Notifications
You must be signed in to change notification settings - Fork 1.6k
misc: replace eslint + prettier with biomejs #3974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ArjixWasTaken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd make it easier to merge if there wasn't all this noise.
Could you unformat all the files?
- Remove ESLint and Prettier configurations and dependencies - Add Biome configuration (biome.jsonc) - Update package.json scripts to use Biome for linting and formatting - Update GitHub workflow to use Biome instead of ESLint - Replace eslint-disable comments with biome-ignore comments - Update README badges from ESLint to Biome - Add Biome VS Code extension recommendation
d8d4930 to
e343e0c
Compare
Enable VCS support in biome.jsonc to respect .gitignore
Unformatted all the files and turned on the ignore file. (Just ignore how it took me 3 tries. I am tired rn) |
Currently translated at 95.8% (437 of 456 strings) Translation: th-ch/youtube-music/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/hu/
pear-devs#3981) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ArjixWasTaken <53124886+ArjixWasTaken@users.noreply.github.com>
Currently translated at 100.0% (456 of 456 strings) Translation: th-ch/youtube-music/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/zh_Hant/
Currently translated at 100.0% (456 of 456 strings) Translation: th-ch/youtube-music/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/nl/
Currently translated at 100.0% (456 of 456 strings) Translation: th-ch/youtube-music/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/nl/
Co-authored-by: ArjixWasTaken <53124886+ArjixWasTaken@users.noreply.github.com>
Currently translated at 91.8% (419 of 456 strings) Translation: th-ch/youtube-music/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/fil/
Currently translated at 100.0% (456 of 456 strings) Translation: th-ch/youtube-music/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/de/
Currently translated at 100.0% (456 of 456 strings) Translation: th-ch/youtube-music/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/pl/
Currently translated at 94.9% (433 of 456 strings) Translation: pear-devs/pear-desktop/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/uk/
Currently translated at 79.1% (361 of 456 strings) Translation: pear-devs/pear-desktop/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/lt/
Currently translated at 62.7% (286 of 456 strings) Translation: pear-devs/pear-desktop/i18n Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/ms/
- Remove ESLint and Prettier configurations and dependencies - Add Biome configuration (biome.jsonc) - Update package.json scripts to use Biome for linting and formatting - Update GitHub workflow to use Biome instead of ESLint - Replace eslint-disable comments with biome-ignore comments - Update README badges from ESLint to Biome - Add Biome VS Code extension recommendation
|
why delete? |
|
Because the way I rebased made it unmergeable. Here is a new one. #4003 It's the same as this one but without merge conflicts because of the sudden rebrand and stuff. I'm sorry. I was being a bit stupid 😭 |
Why?
Biome is an objectively faster linter + formatter as a single dependency instead of having 10 dependencies for eslint.
What does this PR change?