Skip to content

Conversation

@Yumeo0
Copy link
Contributor

@Yumeo0 Yumeo0 commented Oct 4, 2025

Why?
Biome is an objectively faster linter + formatter as a single dependency instead of having 10 dependencies for eslint.

What does this PR change?

  • The styling is only minimally different from prettier so most files changed are only ordered imports.
  • As far as I checked the linting also checks for the same rules as it did with eslint with the settings I put in.
  • The reviewdog workflow is updated to also use Biome.
  • All eslint ignores were replaced with Biome ignores.

Copy link
Member

@ArjixWasTaken ArjixWasTaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd make it easier to merge if there wasn't all this noise.
Could you unformat all the files?

- Remove ESLint and Prettier configurations and dependencies
- Add Biome configuration (biome.jsonc)
- Update package.json scripts to use Biome for linting and formatting
- Update GitHub workflow to use Biome instead of ESLint
- Replace eslint-disable comments with biome-ignore comments
- Update README badges from ESLint to Biome
- Add Biome VS Code extension recommendation
@Yumeo0 Yumeo0 force-pushed the misc/biomejs branch 2 times, most recently from d8d4930 to e343e0c Compare October 4, 2025 23:37
Enable VCS support in biome.jsonc to respect .gitignore
@Yumeo0
Copy link
Contributor Author

Yumeo0 commented Oct 4, 2025

It'd make it easier to merge if there wasn't all this noise. Could you unformat all the files?

Unformatted all the files and turned on the ignore file.

(Just ignore how it took me 3 tries. I am tired rn)

@Yumeo0 Yumeo0 requested a review from ArjixWasTaken October 5, 2025 21:23
Pr1styu and others added 22 commits October 10, 2025 17:49
Currently translated at 95.8% (437 of 456 strings)

Translation: th-ch/youtube-music/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/hu/
pear-devs#3981)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ArjixWasTaken <53124886+ArjixWasTaken@users.noreply.github.com>
Currently translated at 100.0% (456 of 456 strings)

Translation: th-ch/youtube-music/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/zh_Hant/
Currently translated at 100.0% (456 of 456 strings)

Translation: th-ch/youtube-music/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/nl/
Currently translated at 100.0% (456 of 456 strings)

Translation: th-ch/youtube-music/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/nl/
Co-authored-by: ArjixWasTaken <53124886+ArjixWasTaken@users.noreply.github.com>
Currently translated at 91.8% (419 of 456 strings)

Translation: th-ch/youtube-music/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/fil/
Currently translated at 100.0% (456 of 456 strings)

Translation: th-ch/youtube-music/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/de/
Currently translated at 100.0% (456 of 456 strings)

Translation: th-ch/youtube-music/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/pl/
Currently translated at 94.9% (433 of 456 strings)

Translation: pear-devs/pear-desktop/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/uk/
Currently translated at 79.1% (361 of 456 strings)

Translation: pear-devs/pear-desktop/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/lt/
Currently translated at 62.7% (286 of 456 strings)

Translation: pear-devs/pear-desktop/i18n
Translate-URL: https://hosted.weblate.org/projects/youtube-music/i18n/ms/
- Remove ESLint and Prettier configurations and dependencies
- Add Biome configuration (biome.jsonc)
- Update package.json scripts to use Biome for linting and formatting
- Update GitHub workflow to use Biome instead of ESLint
- Replace eslint-disable comments with biome-ignore comments
- Update README badges from ESLint to Biome
- Add Biome VS Code extension recommendation
@Yumeo0 Yumeo0 closed this Oct 10, 2025
@Yumeo0 Yumeo0 deleted the misc/biomejs branch October 10, 2025 16:07
@ArjixWasTaken
Copy link
Member

ArjixWasTaken commented Oct 10, 2025

why delete?
I was just delaying the merge because we have other priorities rn

@Yumeo0
Copy link
Contributor Author

Yumeo0 commented Oct 10, 2025

Because the way I rebased made it unmergeable. Here is a new one. #4003

It's the same as this one but without merge conflicts because of the sudden rebrand and stuff.

I'm sorry. I was being a bit stupid 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.