This repository was archived by the owner on Feb 1, 2026. It is now read-only.
Merged
Conversation
ashnazg
approved these changes
Nov 24, 2024
Contributor
Author
|
Thanks for merging this @ashnazg. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Currently, the code is not compatible with PHP 8. This PR is a first step toward this.
In order to be able to run the test suite on a large span of PHP versions, this PR converts it to PHPUniPolyFills. With this the command
vendor/bin/phpunit testsruns with PHP 7.4 without modifying the code (and with some simple modifications, it runs with PHP 8.3).This is similar to pear/HTML_Template_IT#17.
Technical details
I constrained PHP versions in
composer.json.There is almost no change to the test suite itself except:
Yoast\PHPUnitPolyfills\TestCases\TestCaseso they must implementset_up/tear_down(instead ofsetUp/tearDown). See the doc here.AllTests.phpbecause I could not port it. AFAIU, it doesn't change the tests.assertInternalTypebyassertIsArray.