Support fetching subject token from url for workload identity#179
Merged
wojtekmach merged 1 commit intopeburrows:masterfrom Dec 20, 2024
Merged
Conversation
|
Can confirm Goth was unable to authenticate with Google Cloud during a GH run before this change, and is now able after this change. Good changes @slackersoft! |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to fetch the
subject_tokenfor a workload identity from a url. Also added some documentation intoken.exfor using:workload_identity. This allows us to use workload identity directly without any additional steps in our CI actions based on how we have configured workload identity.I was able to get it working with the previous commits to
masterhere, by making an additionalcurl, but with this we can just use the credentials json directly