Merge dev-implicit-chem-7sp-supg-tested, reimplementing streamwise stability for lomach solvers #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gFlow, and tomboulides
Contributor
|
@garobed1, I just marked this PR as a draft to make it clear it is still in progress and not quite ready for review. |
…-chem-7sp-supg-tested
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented streamwise stability for calorically_perfect, tomboulides, and reactingFlow using MFEM coefficients, using effectively the same calculation as Sigfried in dev-expStreamwiseStabilization. It supports 2D, 3D, and axisymmetric 2D. Numerically, the implementation passes the original test that Sigfried used in his branch, which I have added to this one as well.
There are two issues: Certain tests don’t pass in general, in particular
test_tomboulides.cpp, which fails because I added an additional argument to the physics module constructors to pass the grid scale in, similar to the turbulence models. Any other constructor call will need to be modified somehow, but I don’t have a straightforward way of doing so at the moment.The other issue is that runs with streamwise stabilization enabled crash at the very end:
This has been occurring for all of my regular runs. I suspect there might be something going on with pointer deletion in the destructor, but I haven’t found the culprit yet.
Finally, I left off my current implementation of ramping chemistry changes. Perhaps we can discuss that with the interested parties on the Boltzmann side as well.