Skip to content

Proposal delete#6

Open
MischaD wants to merge 7 commits intopeerplays-network:masterfrom
MischaD:proposal_dele
Open

Proposal delete#6
MischaD wants to merge 7 commits intopeerplays-network:masterfrom
MischaD:proposal_dele

Conversation

@MischaD
Copy link
Copy Markdown

@MischaD MischaD commented Jan 9, 2019

No description provided.

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

@pbattu123 please review

@pbattu123
Copy link
Copy Markdown
Contributor

@pbattu123 please review

I have reviewed the updates and everything looks fine except the following things.

  1. Looks like eventgroup_delete method needs to be added in python-peerplays library.
  2. Need to handle a scenario where sport delete proposal is pending and user try to delete corresponding event group(I didn't get a chance to test this)

@sschiessl-bcp
Copy link
Copy Markdown
Contributor

@pbattu123 please review

I have reviewed the updates and everything looks fine except the following things.

  1. Looks like eventgroup_delete method needs to be added in python-peerplays library.
  2. Need to handle a scenario where sport delete proposal is pending and user try to delete corresponding event group(I didn't get a chance to test this)

Is that wrongly copy & pasted?

@pbattu123
Copy link
Copy Markdown
Contributor

@pbattu123 please review

I have reviewed the updates and everything looks fine except the following things.

  1. Looks like eventgroup_delete method needs to be added in python-peerplays library.
  2. Need to handle a scenario where sport delete proposal is pending and user try to delete corresponding event group(I didn't get a chance to test this)

Is that wrongly copy & pasted?

@pbattu123 please review

I have reviewed the updates and everything looks fine except the following things.

  1. Looks like eventgroup_delete method needs to be added in python-peerplays library.
  2. Need to handle a scenario where sport delete proposal is pending and user try to delete corresponding event group(I didn't get a chance to test this)

Is that wrongly copy & pasted?

Sorry, it was wrong copy
The actual review comment is proposal_delete not implemented or committed to python-peerplays library.

@MischaD
Copy link
Copy Markdown
Author

MischaD commented Feb 22, 2019

proposal_delete implementation is an open pull request for python-peerplays. Needs to be merged before proposal delete works. python-peerplays/pull/19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants