fix(jit): update cranelift-frontend 0.127 API and reformat for edition 2024#42
Open
fix(jit): update cranelift-frontend 0.127 API and reformat for edition 2024#42
Conversation
…n 2024 cranelift-frontend 0.127 changed declare_var from taking (variable, type) to taking only (type) and returning the Variable. The old 2-arg calls in compiler.rs caused E0061 compilation errors in CI. Additionally, the crate uses Rust edition 2024, which introduced new rustfmt defaults (sorted imports, different line-wrapping thresholds). Running cargo fmt brings all source files into compliance. - Remove EntityRef and Variable imports from compiler.rs - Replace Variable::new(n) + declare_var(var, ty) with declare_var(ty) - Prefix unused `compiler` binding with underscore in jit/mod.rs - Apply cargo fmt across all source files for edition 2024 style
|
This pull request has been automatically marked as stale because it has not had recent activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare_varcalls to match cranelift-frontend 0.127 API (now takes only type, returns Variable)cargo fmtacross all source files for Rust edition 2024 style complianceRoot Cause
Dependabot bumped cranelift-frontend from 0.113 to 0.127 (#24), which changed the
FunctionBuilder::declare_varsignature fromdeclare_var(variable, type)todeclare_var(type) -> Variable. This broke CI with 4E0061errors.Test plan
cargo checkpasses locallycargo fmt --checkpasses locally