Fix ordering and improve South Korean labels in English/non-Korean#59
Merged
orangejulius merged 6 commits intomasterfrom Aug 27, 2025
Merged
Fix ordering and improve South Korean labels in English/non-Korean#59orangejulius merged 6 commits intomasterfrom
orangejulius merged 6 commits intomasterfrom
Conversation
missinglink
force-pushed
the
korean-label-ordering
branch
3 times, most recently
from
f716151 to
76af7d0
Compare
missinglink
commented
Aug 26, 2025
|
|
||
| return language.toUpperCase(); | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
this block was unused
In South Korea, we can probably simplify labels a bit, and only include province info if needed because there was no locality or localadmin info.
orangejulius
force-pushed
the
korean-label-ordering
branch
from
76af7d0 to
e707273
Compare
orangejulius
changed the title
orangejulius
changed the title
Member
Author
|
Looks good to me |
Member
Author
|
I tested this out and it's much improved now. One thought I had was about how users requesting East Asian languages view each other's labels, for instance in this example the target geography is Korean but target language is Japanese, the result is the default English decorator despite both having custom decorators. 
|
orangejulius
approved these changes
Aug 27, 2025
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Aug 27, 2025
This includes Korean label fixes from pelias/labels#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received a bug report that label fields are returned in reverse order for Korean documents in the English language:
https://pelias.github.io/compare/#/v1/search?text=seoul%2C+korea
I believe the intention of the original PR was to only display the fields in inverse order when displaying them in the Korean language such as this:
This PR uses the multi-language configuration options introduced in #51 to build better default labels for South Korean places. These will be used whenever the desired language is not Korean.
ref: https://github.com/pelias/api/blob/f7735b9117633f8bb8d30ffd3a905326b9a450ee/middleware/assignLabels.js#L21