Skip to content

Comments

tags: map alternate names to individual fields#567

Draft
missinglink wants to merge 1 commit intomasterfrom
additional-name-fields
Draft

tags: map alternate names to individual fields#567
missinglink wants to merge 1 commit intomasterfrom
additional-name-fields

Conversation

@missinglink
Copy link
Member

partner PR for pelias/api#1620

@missinglink missinglink force-pushed the additional-name-fields branch 5 times, most recently from 16de14b to d56bd71 Compare April 1, 2022 10:20
@missinglink missinglink force-pushed the additional-name-fields branch from d56bd71 to 55f13ca Compare April 1, 2022 10:21
@missinglink
Copy link
Member Author

I've kicked off a full planet build @additional-name-fields-2022-04-01-55f13ca329927bcfa31a576504b9920801ee9046

@missinglink
Copy link
Member Author

this looks promising, grepping the fixture file shows that all name fields now only contain a single entry

@orangejulius
Copy link
Member

orangejulius commented Apr 14, 2022

Yeah, the POI test cases for major landmarks look very good with this change.

Just for some context, here's some relevant tests "before":
image

And "after" the changes as of around April 5th:
image

In particular the results for "Statue of Liberty" and "Phoenix International Airport" look a lot better.

Note that the percentage pass rate shows an improvement only from 84 to 86%, but the actual increase is a lot higher, since most of the tests are expected to fail. In actuality, there's a net increase of 25 new requests passing, or a 6% improvement. Considering there are a few regressions that might either be a testing artifact or something we can fix, and the nature of many of these autocomplete queries meaning many of the shorter test cases won't ever pass, that's pretty good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants