Add php 8.5 and make it recommended version #187
Conversation
✅ Deploy Preview for pelica ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughDocumentation updates across four guides to reflect PHP version upgrade from 8.4 to 8.5. Changes include installation instructions, webserver configurations (NGINX, Apache, Caddy), version compatibility tables, and related socket path references. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/guides/php-upgrade.mdx (1)
19-20: Minor style suggestion.Consider simplifying "In order to install" to just "To install" for conciseness.
📝 Suggested wording
-In order to install PHP 8.5, you will need to run the following commands. Please keep in mind different operating systems +To install PHP 8.5, you will need to run the following commands. Please keep in mind different operating systems
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/guides/php-upgrade.mdxdocs/panel/getting-started.mdxdocs/panel/update.mdxdocs/panel/webserver-config.mdx
🧰 Additional context used
🪛 LanguageTool
docs/guides/php-upgrade.mdx
[style] ~18-~18: Consider a more concise word here.
Context: ...| 8.2, 8.3, 8.4, 8.5 | ## Install PHP In order to install PHP 8.5, you will need to run t...
(IN_ORDER_TO_PREMIUM)
🔇 Additional comments (8)
docs/panel/update.mdx (1)
15-17: LGTM!PHP 8.5 was released on November 20, 2025, so adding it to the supported versions table is appropriate. The table formatting is consistent with the existing structure.
docs/panel/getting-started.mdx (1)
48-48: LGTM!The upgrade from PHP 8.4 to 8.5 should be straightforward for most applications. If you're already using PHP 8.4, upgrading to PHP 8.5 is recommended. Making PHP 8.5 the recommended version while maintaining support for older versions is the right approach.
docs/panel/webserver-config.mdx (3)
15-15: LGTM!NGINX configuration changes are consistent: the warning admonition and both HTTPS/HTTP socket paths are correctly updated to
php8.5-fpm.sock.Also applies to: 78-78, 128-128
233-241: LGTM!Apache configuration changes are consistent: the warning admonition and
a2enmod php8.5command are correctly updated.
253-253: LGTM!Caddy configuration changes are consistent: the warning admonition and both HTTPS/HTTP
php_fastcgisocket paths are correctly updated tophp8.5-fpm.sock.Also applies to: 284-284, 337-337
docs/guides/php-upgrade.mdx (3)
13-15: LGTM!Version table correctly updated to include PHP 8.5 as a supported version for Panel 1.0.0+.
30-31: LGTM!Package names correctly updated to PHP 8.5 with all required extensions.
38-45: LGTM!All webserver configuration sections (NGINX, Apache, Caddy) are consistently updated to reference PHP 8.5:
- sed commands correctly replace with
php8.5-fpm.sock- Apache module command updated to
a2enmod php8.5Also applies to: 55-59, 63-69
| ### Dependencies | ||
|
|
||
| For the Panel you need to install **PHP `8.4` (recommended), `8.3` or `8.2`**, with the following **extensions**: | ||
| For the Panel you need to install **PHP `8.5` (recommended), `8.4`, `8.3` or `8.2`**, with the following **extensions**: |
There was a problem hiding this comment.
Do we really want to recommend php8.5 when its only out since a month and a half ?
There was a problem hiding this comment.
Why not? I don't think it's unstable or anything?
There was a problem hiding this comment.
I don't know if enough testing was done to make sure everything works fine (example locales that were broken)
There was a problem hiding this comment.
I didn't notice any problems in my testings. I also believe that some people already use php 8.5 and they also said on discord that it's fine.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.