Make _create_absolute_fileurl() function more resilient#74
Conversation
_create_absolute_fileurl() function more resilient
justinmayer
left a comment
There was a problem hiding this comment.
Thank you for the fix, Max. I reverted the .gitignore changes, which at the very least belong in their own commit and pull request, but in my opinion are better placed on your own workstation inside ~/.gitignore.
|
That was actually a very nice contribution experience. Your contribution guide is quite good and enabled me to quickly do that. Thanks a lot for the review and creating a new release right away. But what you wrote because of Also it's quite common practice to exclude the paths for the most common environment setups there, i.e. https://github.com/github/gitignore/blob/main/Python.gitignore So what about making the setup a bit more contributor friendly with #75 ? I will keep working this project a bit more, because I see a couple more issues which need to get fixed. Also robots.txt is lacking the sitemap. |
|
Thanks for the kind words about the contribution guide and overall experience. I am aware that some people repeatedly duplicate the same configuration in every repository's My friend Hynek, a well-known Python developer whose opinions I respect, also appears to share my minimalist perspective on this topic: https://github.com/hynek/stamina/blob/main/.gitignore That said, I merged your follow-up PR given the other existing entries in this particular repository. |
|
Thanks for elaborating on this a bit more. I will follow up on this as this an approach I am not familiar with. Maybe it's an idea to add some information about this to your contribution guide. I just finished the sitemap feature for robots.txt and will send you another MR shortly. |
I also updated the .gitignore for my Pycharm IDE and virtual environment.
fixes #66