Implement pallet for mock-skip blocks on runtimes #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanS98
changed the title
ebma
reviewed
Jul 19, 2024
Comment on lines
34
to
38
| #[cfg(test)] | ||
| mod mock; | ||
|
|
||
| #[cfg(test)] | ||
| mod tests; |
Member
There was a problem hiding this comment.
If the whole content of mock and test are only supposed to be used when instant-seal is available, wouldn't it make more sense to instead move the feature flag macro above the mod imports here? Then we can remove all the annotations from the mock.rs and test.rs files itself.
Contributor
Author
There was a problem hiding this comment.
True 👍🏼 I forgot about those macro flags when testing some things earlier
Member
There was a problem hiding this comment.
Maybe we can even move them into the pub mod pallet {} definition? Not sure if that works but then no extra macros were needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new pallet used to mock block skipping when testing wasm-deploy.
The idea behind it is described in this ticket in detail.
I'll add a broader description before marking the PR as ready for review.
Closes #486.