Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of file operations, enhances test coverage for daemon watch management, and makes minor workflow and utility updates. The main focus is on restoring and updating tests for watch-related daemon operations, ensuring that file removals are safe, and making the CI workflow more flexible.
Testing improvements for daemon watch management:
tests/daemon_test.rsforhandle_stop_watch,handle_up_watch,handle_rm_watch, andhandle_list_watches, using a newbuild_repohelper and modernized context setup. These tests now more accurately reflect real usage and improve coverage for core daemon operations. [1] [2] [3]Robustness and utility enhancements:
rm_metrics_by_idinsrc/exec/metrics.rsto check if the metrics file exists before attempting to remove it, preventing errors if the file is missing.Workflow and CI updates:
.github/workflows/ci.ymlto prepare necessary directories before running tests and included thescheduler_testin the test suite. Also removed the restriction that tests only run on push events. [1] [2]Minor codebase changes:
handle_stop_watchinsrc/daemon/server.rspublic to allow direct testing and potential reuse.tests/scheduler_test.rsto aid in diagnosing pipeline test runs.