PG-1959: Workaround for incorrect Vault response #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutow
force-pushed
the
pg1959b
branch
2 times, most recently
from
69b3d39 to
71a2d35
Compare
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (59.70%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 59.67% 59.70% +0.02%
==========================================
Files 67 67
Lines 10473 10487 +14
Branches 1805 1803 -2
==========================================
+ Hits 6250 6261 +11
- Misses 3528 3531 +3
Partials 695 695
🚀 New features to boost your workflow:
|
AndersAstrand
approved these changes
Dec 4, 2025
Collaborator
AndersAstrand
left a comment
AndersAstrand
left a comment
There was a problem hiding this comment.
Looks good
I'm not at all sure what parse->level encodes here that's not already encoded in the parse states, but that's out of scope for this PR.
Hashicorp Vault sends a different response when using namespaces compared to the "normal" responses for the mount path info: instead of all information available at the top level and inside the data subobject, it is only available inside data. This commit modifies the parser to retrieve fields inside data instead, so it works in all situations.
If we can't access the mount point info, we emit a warning instead of an error. This shown users that we weren't able to verify their setup without completely blocking the use of the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashicorp Vault sends a different response when using namespaces compared to the "normal" responses for the mount path info: instead of all information available at the top level and inside the data subobject, it is only available inside data.
This commit modifies the parser to retrieve fields inside data instead, so it works in all situations.