Skip to content

PMM-13837 valkey on pmm agent #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
May 28, 2025

drop unused redis scheme

c16b3c6
Select commit
Loading
Failed to load commit list.
Merged

PMM-13837 valkey on pmm agent #4014

drop unused redis scheme
c16b3c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 27, 2025 in 0s

43.65% (+0.00%) compared to 33c3f71

View this Pull Request on Codecov

43.65% (+0.00%) compared to 33c3f71

Details

Codecov Report

Attention: Patch coverage is 39.06250% with 39 lines in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (33c3f71) to head (c16b3c6).

Files with missing lines Patch % Lines
managed/services/agents/valkey.go 0.00% 19 Missing ⚠️
agent/agents/supervisor/supervisor.go 0.00% 5 Missing ⚠️
agent/tlshelpers/valkey.go 44.44% 4 Missing and 1 partial ⚠️
managed/models/agent_model.go 0.00% 5 Missing ⚠️
managed/services/victoriametrics/scrape_configs.go 70.00% 2 Missing and 1 partial ⚠️
managed/services/agents/state.go 0.00% 1 Missing ⚠️
managed/services/converters.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                    @@
##           PMM-13576-valkey-support    #4014   +/-   ##
=========================================================
  Coverage                     43.65%   43.65%           
=========================================================
  Files                           372      372           
  Lines                         45614    45665   +51     
=========================================================
+ Hits                          19911    19937   +26     
- Misses                        23980    24004   +24     
- Partials                       1723     1724    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov