Add Support for FFmpeg version 5.0..7.1.1#57
Conversation
…hen using cmake 4.0 which deprecated versions below 3.10
…f FFmpeg This code builds with FFmpeg versions 3.1..3.4, 4.0..4.4, 5.0, 5.1, 6.0, 6.1, 7.0 and 7.1. Because FFmpeg changed a lot support for 3.0 and earlier has been dropped, 3.0 being released on 2016-02-14.
…he if statement Seems the msvc build being used to compile it for Windows doesn't support the c++17 feature
Baklap4
left a comment
Baklap4
left a comment
There was a problem hiding this comment.
Changes are looking good thanks a lot!
I'll give this a testrun later today :)
Baklap4
left a comment
Baklap4
left a comment
There was a problem hiding this comment.
Looks good overal let's fix a couple of things noted then let's merge it so we can enable the ci/cd again 👍 thanks for the PR!
Baklap4
left a comment
Baklap4
left a comment
There was a problem hiding this comment.
LGTM; however pipelines are still failing.. and i'm not quite sure why; I'll take a look at them :)
|
I have no idea how the pipline and everything works but seems that actions/upload-artifact@v3 was deprecated back in 2024 and has been removed since January 30th 2025 according to https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/. |
Baklap4
force-pushed
the
support-newer-ffmpeg
branch
from
19bbb25 to
188f46d
Compare
|
Download the artifacts for this pull request:
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time. |
Baklap4
force-pushed
the
support-newer-ffmpeg
branch
from
188f46d to
c46604b
Compare
Thanks for pushing me in the right direction.
aparently we if we don't do anything in the docker or workflow folder then we don't create the docker repository. This causes issues when the repository does not yet exist.. Amended readme changes into the previous commit. |
Baklap4
force-pushed
the
support-newer-ffmpeg
branch
from
9110b41 to
29c16e4
Compare
Baklap4
left a comment
Baklap4
left a comment
There was a problem hiding this comment.
Let's get this merged; After that i'll update the required checks for future PR's
Thanks a bunch for helping out 🎉
2 participants
What does this PR do?
Updates the FFmpeg code in ffmpeg.cc and ffmpeg.hh so that the code used is using modern apis and makes it build with newer FFmpeg releases. Also made it so there are no deprecation warnings anymore in the versions tested.
Motivation
The FFmpeg code in use no longer build with FFmpeg 5.0 or newer and for FFmpeg 3.1 and newer it was giving deprecation warnings for functions that were being used. This makes it easier for someone to develop on this project on a more modern system than one that comes with an FFmpeg version younger than 3.1.
Additional Notes
I tested this in a Kubuntu 24.04 vm and tested all versions from 3.1 all the way up to the latest 7.1.1 release.
So that's 3.1, 3.2, 3.3, 3.4, 4.0, 4.1, 4.2, 4.3, 4.4, 5.0, 5.1, 6.0, 6.1, 7.0 and 7.1.
QT5 version on this machine is 5.15.13.
Because of removed apis this now no longer works with FFmpeg version 3.0 and lower.