adjust stale join refs behavior introduced in c73bbfc to be more backwards compatible#4
Merged
lee-reinhardt merged 1 commit intoconnect-infofrom Jan 8, 2026
Merged
Conversation
…wards compatible
danielspofford
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
c73bbfcfintroduced strictjoin_refvalidation that silently drops messages from clients (like Slipstream) that don't includejoin_refin push messages.The fix adds
join_ref == nilto the guard, allowing nil join_ref from clients while still rejecting stale/mismatched join_refs.