chore: remove net8 dependency and target netstandard2.1#141
Closed
chore: remove net8 dependency and target netstandard2.1#141
Conversation
frozzare
force-pushed
the
netstandard-target
branch
from
39b83a2 to
9554081
Compare
frozzare
force-pushed
the
netstandard-target
branch
from
9554081 to
cdb5851
Compare
| [ClassData(typeof(ValidCnDataProvider))] | ||
| public void TestAgeCn(PersonnummerData ssn) | ||
| { | ||
| var timeProvider = new TestTimeProvider(); |
Member
There was a problem hiding this comment.
I think we want to keep the TimeProvider, seeing its a dotnet implementation of what the Clock does and made for making code easier to test :)
Its a bit messy due to the Pragmas for DOTNET_8, but its a minor diff between netstandard/net8+ versions. And it's only really there to allow support for dotnet framework.
| <PackageIcon>icon.png</PackageIcon> | ||
| <PackageReadmeFile>Readme.md</PackageReadmeFile> | ||
| <IncludeDocumentationProjectOutputGroup>true</IncludeDocumentationProjectOutputGroup> | ||
| <TargetFramework>netstandard2.1</TargetFramework> |
Member
There was a problem hiding this comment.
I think we might want to directly target some of the versions. Will have to think about this one and if there are issues with just targeting netstandard...
It would ofc make it easier code-wize, but unsure if its the best way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Simplify code and target only netstandard2.1
Related issue
Motivation
Checklist