Merged
Conversation
The great functionality of wandb sweeps cannot be used out of the box with edflow. The new `edprep` command helps with this. Now you can 1. Define a sweep from you wandb client 2. edprep the sweep.yaml so that it is compatible with edflow 3. run the wandb sweep For more details the the docstring in edprep
This is specific only to the --base arguemnt of the edflow and thus edprep command. The current hack is to simpy join a list using a space. This is hacky and will probably lead to errors in the future, should the commandline interaface be extended.
The additional test confirms, that a mixture of wandb-type (depth by dot) and edflow-type (depth by slash) arguments are converted to purely edflow-type arguemnts, resulting in a correct config dict.
pesser
requested changes
Apr 16, 2020
Owner
pesser
left a comment
pesser
left a comment
There was a problem hiding this comment.
Looks great, I'm looking forward to trying it! Let me know about my comment and we can merge
pesser
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Could you merge my #253 pull request first?)
The great functionality of wandb sweeps cannot be used out of the box
with edflow. The new
edprepcommand helps with this. Now you canFor more details the the docstring in edprep
There are two changes that maybe need discussion:
-t, -d) to a custom type, which should yield the same behavior as before but also allow for the explicit passing of the boolean arguments in various forms. This is necessary, as wandb needs to get all arguments passed to edflow in a specific form, after which it will pass them explicitly as--key=valuepairs. I have not encountered problems with this new handling, but would like to make sure that a second brain wraps itself around this problem.