refactor: generate study ids using review-specific sequence#213
Merged
lucas-ifsp merged 2 commits intomainfrom Mar 11, 2026
Merged
refactor: generate study ids using review-specific sequence#213lucas-ifsp merged 2 commits intomainfrom
lucas-ifsp merged 2 commits intomainfrom
Conversation
lucas-ifsp
requested changes
Mar 4, 2026
Collaborator
lucas-ifsp
left a comment
lucas-ifsp
left a comment
There was a problem hiding this comment.
@Erick-Rosdachimo note que o PR não está passando nas rotinas de verificação automáticas (SonarCube e build). Provavelmente você não atualizou os casos de teste para trabalharem com as novas assinaturas de métodos. Nenhum teste pode estar quebrado quando o PR chega. Por favor, atualize os testes e reenvie o PR.
|
lucas-ifsp
requested changes
Mar 9, 2026
Collaborator
lucas-ifsp
left a comment
lucas-ifsp
left a comment
There was a problem hiding this comment.
@Erick-Rosdachimo a esteira de CI ainda tá indicando teste quebrando (CreateStudyReviewServiceImplTest). Veja se está tudo ok mesmo. Rode os testes de todos os módulos antes do PR (i.e., review, Web e account)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.