Skip to content

fix: ignore comments (%) when parsing BibTeX files #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucas-ifsp merged 2 commits into from
Mar 11, 2026
Merged

fix: ignore comments (%) when parsing BibTeX files #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a0b51
fix: ignore comments (%) when parsing BibTeX files
Gnbocute Mar 6, 2026
fdb729e
fix(bibtex): correctly split entries to avoid breaking on emails
Gnbocute Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion review/src/main/kotlin/br/all/domain/services/BibtexConverterService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,12 @@ class BibtexConverterService(private val studyReviewIdGeneratorService: IdGenera
}

private fun convertMany(bibtex: String): Pair<List<Study>, List<String>> {
val cleanedBibtex = removeBibtexComments(bibtex)

val validStudies = mutableListOf<Study>()
val invalidEntries = mutableListOf<String>()

bibtex.split(Regex("(?=\\s*@)"))
cleanedBibtex.split(Regex("(?m)(?=@\\w+\\s*\\{)"))
.map { it.trim() }
.filter { it.isNotBlank() }
.forEach { entry ->
Expand Down Expand Up @@ -111,6 +113,20 @@ class BibtexConverterService(private val studyReviewIdGeneratorService: IdGenera
return Study(type, title, year, authors, venue, abstract, keywords, references, doi)
}

private fun removeBibtexComments(bibtex: String): String {
return bibtex.lines()
.mapNotNull { line ->
if (line.trimStart().startsWith("%")) {
null
} else {
val commentIndex = line.indexOf('%')
val cleaned = if (commentIndex >= 0) line.take(commentIndex) else line
cleaned.trimEnd().takeIf { it.isNotBlank() }
}
}
.joinToString("\n")
}

private fun parseBibtexFields(bibtexEntry: String): Map<String, String> {
val content = bibtexEntry.substringAfter('{', "").substringBeforeLast('}', "")
if (content.isBlank()) {
Expand Down
Loading