feat: Add an attribute to show the modal on mounted#150
Open
RyoWakabayashi wants to merge 2 commits intopetalframework:mainfrom
Open
feat: Add an attribute to show the modal on mounted#150RyoWakabayashi wants to merge 2 commits intopetalframework:mainfrom
RyoWakabayashi wants to merge 2 commits intopetalframework:mainfrom
Conversation
mplatts
reviewed
Feb 28, 2023
| ) | ||
|
|
||
| attr(:show_on_mounted, :boolean, | ||
| default: false, |
Contributor
There was a problem hiding this comment.
Hmm this would mean everyone who upgrades will have their modals stop working? maybe we could reverse it - "hide_on_mounted", defaults to false?
mplatts
reviewed
Feb 28, 2023
| unless show_on_mounted do | ||
| %JS{} | ||
| |> JS.remove_class("overflow-hidden", to: "body") | ||
| |> JS.hide(to: "#modal-overlay") |
Contributor
There was a problem hiding this comment.
just wondering why we need to hide so many things?
Author
There was a problem hiding this comment.
Certainly there was no need to hide so much.
I'll Add commits immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest adding an attribute that allows the modal to be hidden when mounted
if show_on_mounted is set to false, the modal is not displayed when mounted