Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR integrates a new ChatBubble component into PetalComponents with varied styles and includes tests for each variant.
- Added comprehensive ChatBubble variants in
/lib/petal_components/chat_bubble.exbased on thekindattribute. - Integrated ChatBubble into the public API via updates in
/lib/petal_components.ex. - Introduced tests in
/test/petal/chat_bubble_test.exsthat cover all variants by checking common container classes. - Noted potential maintenance challenges due to repetitive markup and inconsistent tooltip implementations.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
…d for passing map values and added associated tests
Contributor
|
Thanks for this! I think you may still need to push up the css for the |
Contributor
Author
|
Ah! I missed that part 🙏 Will review 😎 |
… highlighting for consistency
Contributor
Author
|
@nhobes Made some additional adjustments, please lmk if you would like me to keep tinkering and any further suggestions or points for learning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ChatBubble based on example at https://flowbite.com/docs/components/chat-bubble/ minus dropdown menu. Awaiting feedback.