Update citier to Rails 4 #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the parent record saved, we already get the id of the child record. If we do the query before child record persisted into the table, it will raise RecordNotFound exception.
If the citier class has the serialized fields in parent/child table, it should be saved using the specified coder and also quoted correctly. It need two changes to make it work. 1. Detect the serialized attributes of the child table. 2. Pass the internal @attributes to parent object and child object for persist.
Single quote or double quote only works for some DB and we should use the AR builtin method to give a workaround
Conflicts: lib/citier/class_methods.rb
overwrite parent's type column when both tables have type column
overwrite parent's type column when both tables have type column
overwrite parent's type column when both tables have type column.
add self_type to memorize current type.
Conflicts: lib/citier/core_ext.rb
Pull chaofan work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.