Insert a INSTALL_PREFIX to set where to put the mirror#5
Open
Stef-33560 wants to merge 2 commits intopeter279k:masterfrom
Stef-33560:master
Open
Insert a INSTALL_PREFIX to set where to put the mirror#5Stef-33560 wants to merge 2 commits intopeter279k:masterfrom Stef-33560:master
Stef-33560 wants to merge 2 commits intopeter279k:masterfrom
Stef-33560:master
Conversation
Mistake in purge_answer !
peter279k
reviewed
Aug 31, 2022
| @@ -0,0 +1 @@ | |||
| INSTALL_PREFIX="/var/repos/mirror-kickstarter" No newline at end of file | |||
Owner
There was a problem hiding this comment.
.env I think it should be the optional file.
I think it should create the .env.example file and let the .env file be under the .gitignore file.
And add some .env setting descriptions in the README.md.
peter279k
reviewed
Aug 31, 2022
| ${sudo_prefix}chmod 0600 /var/spool/cron/crontabs/root | ||
| ${sudo_prefix}systemctl restart cron | ||
|
|
||
Owner
There was a problem hiding this comment.
The space is additional and it should be removed.
peter279k
reviewed
Aug 31, 2022
| listen [::]:80 default_server; | ||
|
|
||
| root /var/www/html/mirror/public; | ||
| root /var/repos/mirror/public; |
Owner
There was a problem hiding this comment.
If using the install prefix setting, it should modify the Nginx config file programmatically.
Please refer following steps:
- Revert the
nginx-default.conffile. - After running the command, using the
sedcommand to replace the/var/www/html/mirror/publicsetting with theINSTALL_PREFIXvariable in the/etc/nginx/sites-available/default.
peter279k
reviewed
Aug 31, 2022
| echo -e "${green_color}Import key for remote Nginx mirror...${rest_color}" | ||
| echo "deb http://ppa.launchpad.net/ondrej/nginx/ubuntu $(lsb_release -sc) main" | ${sudo_prefix}tee -a /etc/apt/sources.list.d/ondrej.list | ||
| echo "deb-src http://ppa.launchpad.net/ondrej/nginx/ubuntu $(lsb_release -sc) main" | ${sudo_prefix}tee -a /etc/apt/sources.list.d/ondrej.list | ||
|
|
Owner
There was a problem hiding this comment.
Why deprecating the ondrej/php?
This repository always updates the latest PHP versions and it's not old. The repository is available here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
To allow the mirror to be installed in another folder than
/var/www/html, I've introduced anINSTALL_PREFIXvariable.I took the opportunity to
mirror.config.phpandnginx-default.confIs it usefull for you ?