Conversation
|
BTW all tests now pass in @drowe67's repo: https://github.com/drowe67/radae/actions/runs/22817405233 |
|
@tmiw - nice work, this is just what we needed to connect Peter's fine work with the the essential (IMHO) existing RADE QA. 👍 Any thoughts on the remaining TODOs in drowe67/radae#66 ? Might be useful if we have a test for SNR est (I could help there). @peterbmarks - Claude might be able to help with a BPF test. |
|
@tmiw @peterbmarks - we also need to make sure the ctests are run on every push, then Claude can get used to running them as Peter works with Claude on the code. |
SNR might be reading closer to reference Python now based on my limited testing. Still would need a test written to know for sure, though. (Maybe just run |
|
Re SNR I think we're missing a test in the V1 Python tests, e.g. V1 Python est SNR versus actual SNR. That could then be used for the C Port like the other tests. I'm traveling atm - will get back to you in a few days once I can sit down and think about it. Re BPF we have a pretty good test design for V1 Python, might be possible to get Claude to come up with something similar for C. The BPF definitely has the potential to mess up performance is subtle ways. |
|
One of the reasons I'm interested in SNR is it directly measures the noise of the recovered symbols, so is an indication of the performance of the C demodulator implementation. |
|
I reduced the max loss back down to 0.2 for EDIT: still failing on GH, not sure why. |
|
OK, I think I got rx_slip_minus to pass (pending GH execution). See #2. |
|
@tmiw @peterbmarks - Claude & I are building up a BER test for the C Port that will require a PR for radae_nopy. Should I submit the PR against this repo or Mooneer's fork? |
I'd say this one, once #2 merges. (pinging @peterbmarks so this can happen) |
Improves EOO encoding and decoding:
a. Update RX phase calculation to more closely match Python implementation and reduce floating-point losses.
b. BPF: Updates phase calculation to more closely match Python implementation and improve calculation accuracy.