Merged
Conversation
Collaborator
Author
|
I'm going to quickly build ms-rade-nopy from freedv-gui with this PR and see if the reporting tests all pass there. |
Closed
Collaborator
|
@peterbmarks both @tmiw & I are OK to merge this. If you are busy just let us know and either one of us can hit the green button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates EOO TX to apply pilot gain/tanh after executing IDFT. Previously this was done before IDFT, which didn't match up with the reference Python implementation.
Relevant Python code below:
@drowe67 @peterbmarks