Skip to content

Add OpenLASIR protocol support#48

Open
danielweidman wants to merge 1 commit intopeterhinch:masterfrom
danielweidman:master
Open

Add OpenLASIR protocol support#48
danielweidman wants to merge 1 commit intopeterhinch:masterfrom
danielweidman:master

Conversation

@danielweidman
Copy link

Hi there! I have created a new standard for DIY electronic devices (such as DEF CON badges) to be (potentially) compatible with one another, called OpenLASIR. The IR layer is similar to NEC Extended but with 8 bit address (error checked) and 16 bit command (not error checked).

To make it as easy as possible for makers, I'd really love it if support could get merged into micropython_ir. I recognize that it's a pretty specialized use case, but I'm hoping you will consider accepting this since it is only the creation of new protocol files within ir_rx and ir_tx/, with no modification of the main classes. So I think the risk is minimal.

Obviously it is up to you though! Regardless, thanks so much for your (many) contributions to the MicroPython community!

@peterhinch
Copy link
Owner

You've evidently put some work into this! It seems a reasonable enhancement. However...

I'm not keen on supporting the protocol: as far as I can see there are no actual devices on sale which use it (the badge is sold out). In general I'm reluctant to accept PR's for hardware I don't possess - it's a potential support nightmare.

The best approach is probably for you to maintain a fork. I would happily accept a docs PR pointing protocol users to your fork.

@danielweidman
Copy link
Author

You've evidently put some work into this! It seems a reasonable enhancement. However...

I'm not keen on supporting the protocol: as far as I can see there are no actual devices on sale which use it (the badge is sold out). In general I'm reluctant to accept PR's for hardware I don't possess - it's a potential support nightmare.

The best approach is probably for you to maintain a fork. I would happily accept a docs PR pointing protocol users to your fork.

Certainly fair enough! Feel free to close this PR. I'll just keep the openlasir classes here (along with the code for converting to and from meaningful packet definitions) unless you think a whole fork of the repo is better.

For some context--the device that is sold out is last year's model (I should update the website to clarify as much), the new one will be available in a few months (happy to send you one when ready if you're interested). These are for DEFCON (in August), so I am publishing the protocol now in case anyone wants to make compatible devices ahead of time (I got some requests for this last year).

@peterhinch
Copy link
Owner

I'll leave this open. If there is evidence of wider acceptance I'll reconsider merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants