Fix marketing funnel template creation error

[peterod99]

…template

The funnel template creation was failing with "Tenant context not available" error because it relied on RPC get_current_tenant_id for step creation, even though the tenantId was already validated and available in scope.

Changes:

• funnelTemplatesService: Use existing tenantId variable instead of RPC call when inserting funnel_steps and optin_templates
• funnelStepsService: Add optional explicitTenantId parameter with fallback chain (explicit -> RPC -> sessionStorage -> localStorage)

Summary by CodeRabbit

• Bug Fixes
  • Improved tenant context resolution to better handle multi-tenant scenarios with fallback mechanisms, ensuring proper tenant identification during funnel operations and template management.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request modifies tenant context resolution in funnel-related services. The createFunnelStep function now accepts an optional explicit tenant ID parameter with a fallback chain (explicit parameter → RPC call → browser storage), while createFunnelTemplate simplifies its tenant ID assignment by using a pre-validated tenant context instead of making a fresh RPC call.

Changes

Cohort / File(s)	Summary
Tenant context resolution refactoring src/services/funnelStepsService.ts, src/services/funnelTemplatesService.ts	funnelStepsService: Added optional explicitTenantId parameter to createFunnelStep; implemented fallback chain for tenant resolution (explicit → RPC → storage → error). funnelTemplatesService: Replaced RPC-derived currentTenantId with pre-validated tenantId for funnel_steps and optin_templates inserts.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A tenant tale with clearer ways,
No more just RPC calls all days,
Fallbacks nested, storage deep,
Context flows where logic creeps,
Funnel services now stand so bright, ✨

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 5388f9c and db85764.

📒 Files selected for processing (2)

• src/services/funnelStepsService.ts
• src/services/funnelTemplatesService.ts

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}