Skip to content

Fix published funnel not displaying on live page#35

Merged
peterod99 merged 1 commit intomainfrom
claude/fix-funnel-display-zH4Bd
Jan 6, 2026
Merged

Fix published funnel not displaying on live page#35
peterod99 merged 1 commit intomainfrom
claude/fix-funnel-display-zH4Bd

Conversation

@peterod99
Copy link
Copy Markdown
Owner

@peterod99 peterod99 commented Jan 6, 2026

…ages

  • Add status='active' and public_access_enabled=true validation to funnel queries
  • Render PublicChatContainer for agent_chat step types instead of placeholder
  • Fix fallback content to use page_content fields instead of non-existent description field
  • Initialize agent and session when step_type is agent_chat

Summary by CodeRabbit

  • New Features

    • Added agent chat support to public funnels, enabling conversations with AI agents during the funnel experience with session tracking and state management.
  • Improvements

    • Strengthened access controls for public funnels to ensure only active and publicly enabled funnels are accessible across all entry points.

✏️ Tip: You can customize this high-level summary in your review settings.

…ages

- Add status='active' and public_access_enabled=true validation to funnel queries
- Render PublicChatContainer for agent_chat step types instead of placeholder
- Fix fallback content to use page_content fields instead of non-existent description field
- Initialize agent and session when step_type is agent_chat
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 6, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Three public funnel pages now enforce stricter access control by requiring funnels to be active and publicly accessible. The PublicFunnelLanding page gains comprehensive agent chat support, including agent data loading, session initialization, and conditional rendering based on step type.

Changes

Cohort / File(s) Summary
Access Control Enforcement
src/pages/PublicFunnelChat.tsx, src/pages/PublicFunnelOptin.tsx
Added equality filters (status == 'active' and public_access_enabled == true) to funnel lookups. No changes to error handling or control flow logic.
Agent Chat Support & Enhanced Loading
src/pages/PublicFunnelLanding.tsx
Introduced agent state and session state management. Added conditional agent data fetching and publicFunnelService session initialization for 'agent_chat' steps. Implemented handleSessionUpdate callback for session propagation. Added specialized rendering path for agent chat (header with agent branding, PublicChatContainer). Updated content fallbacks (headline/subheadline sources, html_content references). Applied access control filters matching other pages.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Funnels now stand guard with care,
Only active flows laid bare,
Agent whispers find their way,
Sessions bloom, conversations play!


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 588d65c and 784c53e.

📒 Files selected for processing (3)
  • src/pages/PublicFunnelChat.tsx
  • src/pages/PublicFunnelLanding.tsx
  • src/pages/PublicFunnelOptin.tsx

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@peterod99 peterod99 merged commit d69c1ae into main Jan 6, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants