Fix: Explicit UTF-8 encoding for cross-platform file reading#19
Open
AQGitHbu wants to merge 1 commit intopeteromallet:mainfrom
Open
Fix: Explicit UTF-8 encoding for cross-platform file reading#19AQGitHbu wants to merge 1 commit intopeteromallet:mainfrom
AQGitHbu wants to merge 1 commit intopeteromallet:mainfrom
Conversation
On Windows (especially Chinese/Asian locales) and some other systems, the default file encoding is not UTF-8. This causes UnicodeDecodeError when reading session files that contain non-ASCII characters. This fix explicitly specifies encoding="utf-8" in all open() and read_text() calls when reading JSON files. Changes: - Line 82: Add encoding="utf-8" to read_text() in _extract_project_path_from_sessions() - Line 124: Add encoding="utf-8" to open() in _iter_jsonl() - Line 266: Add encoding="utf-8" to read_text() in _load_kimi_work_dirs()
Contributor
|
There are more places that we need to specify You can see other fixes I did to support Windows at woct0rdho/dataclaw@anonymizer...windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows (especially Chinese/Asian locales) and some other systems, the default file encoding is not UTF-8. This causes UnicodeDecodeError when reading session files that contain non-ASCII characters.
Solution
Explicitly specify encoding="utf-8" in all open() and read_text() calls when reading JSON files.
Changes
Benefits