Fix call to make_finding with wrong detail value type

desloppify/app/commands/show/formatting.py

@@ -31,8 +31,13 @@
 ]
 
 
-def format_detail(detail: dict) -> list[str]:
-    """Build display parts from a finding's detail dict."""
+def format_detail(detail: object) -> list[str]:
+    """Build display parts from a finding's detail payload."""
+    if isinstance(detail, str):
+        return [f"detail: {detail}"] if detail else []
+    if not isinstance(detail, dict):
+        return []
+
     parts = []
     for key, label, formatter in DETAIL_DISPLAY:
         value = detail.get(key)
@@ -60,8 +65,6 @@ def format_detail(detail: dict) -> list[str]:
 
 def suppressed_match_estimate(pattern: str, hidden_by_detector: dict[str, int]) -> int:
     """Estimate hidden-match count for a show pattern using detector-level noise totals."""
-    if not isinstance(pattern, str) or not isinstance(hidden_by_detector, dict):
-        return 0
     detector = pattern.split("::", 1)[0]
     return int(hidden_by_detector.get(detector, 0))
 

desloppify/app/commands/show/render.py

@@ -60,7 +60,8 @@ def _print_single_finding(finding: dict, *, show_code: bool) -> None:
     if detail_parts:
         print(colorize(f"      {' · '.join(detail_parts)}", "dim"))
     if show_code:
-        detail = finding.get("detail", {})
+        detail_raw = finding.get("detail", {})
+        detail = detail_raw if isinstance(detail_raw, dict) else {}
         target_line = (
             detail.get("line") or (detail.get("lines", [None]) or [None])[0]
         )

desloppify/languages/_framework/treesitter/phases.py

@@ -80,7 +80,11 @@ def run(path, lang):
                     f"{e['component_count']} disconnected function clusters "
                     f"({e['function_count']} functions) — likely mixed responsibilities"
                 ),
-                detail=f"Clusters: {families}",
+                detail={
+                    "cluster_count": e["component_count"],
+                    "family": families,
+                    "families": e["families"],
+                },
             ))
         if entries:
             potentials["responsibility_cohesion"] = len(entries)

desloppify/tests/commands/test_cmd_show.py

@@ -118,6 +118,13 @@ def test_outliers_truncated(self):
         out_part = [p for p in parts if p.startswith("outliers:")][0]
         assert "f" not in out_part  # Only first 5
 
+    def test_string_detail_is_rendered(self):
+        parts = format_detail("Clusters: alpha, beta")
+        assert parts == ["detail: Clusters: alpha, beta"]
+
+    def test_non_dict_non_string_detail_is_ignored(self):
+        assert format_detail(123) == []
+
 
 # ---------------------------------------------------------------------------
 # build_show_payload

desloppify/tests/lang/common/test_phase_builders.py

@@ -244,6 +244,8 @@ def test_make_cohesion_phase_run_with_entries():
     assert potentials["responsibility_cohesion"] == 1
     assert findings[0]["detector"] == "responsibility_cohesion"
     assert "disconnected function clusters" in findings[0]["summary"]
+    assert findings[0]["detail"]["cluster_count"] == 4
+    assert findings[0]["detail"]["family"] == "network, database, ui, auth"
 
 
 def test_make_unused_imports_phase_run_with_entries():

pyproject.toml

@@ -80,6 +80,7 @@ python_version = "3.11"
 warn_unused_configs = true
 warn_redundant_casts = true
 warn_unreachable = true
+check_untyped_defs = true
 show_error_codes = true
 strict_optional = true
 ignore_missing_imports = true
@@ -97,8 +98,12 @@ files = [
   "desloppify/app/commands/scan/scan_reporting_presentation.py",
   "desloppify/app/commands/scan/scan_reporting_subjective.py",
   "desloppify/app/commands/scan/scan_workflow.py",
+  "desloppify/app/commands/show/formatting.py",
+  "desloppify/app/commands/show/render.py",
   "desloppify/app/cli_support/parser.py",
   "desloppify/app/cli_support/parser_groups.py",
+  "desloppify/engine/_state/filtering.py",
   "desloppify/engine/concerns.py",
+  "desloppify/languages/_framework/treesitter/phases.py",
   "desloppify/languages/_framework/generic.py",
 ]