feat(e3): unify review packet construction paths#228
Open
agustif wants to merge 1 commit intopeteromallet:mainfrom
Open
feat(e3): unify review packet construction paths#228agustif wants to merge 1 commit intopeteromallet:mainfrom
agustif wants to merge 1 commit intopeteromallet:mainfrom
Conversation
This was referenced Mar 4, 2026
cd91f96 to
2858eda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Epic #209 and sub-issues #219 #220 #221.
This refactor removes duplicated review packet assembly logic in
prepare,--run-batches, and--external-startby routing all three through the shared coordinator/builder contract.What Changed
desloppify/app/commands/review/packet/build.pybuild_prepare_next_command(...)prepareto use shared coordinator packet path:desloppify/app/commands/review/prepare.pyresolve_review_packet_context(...)+build_review_packet_payload(...)CommandErrorwith existing guidancedesloppify/app/commands/review/batch/orchestrator.py_load_or_prepare_packet(...)now uses shared context/builder and explicitPacketValidationErrorwrappingblind_path_override=_blind_packet_path()desloppify/app/commands/review/external.py_prepare_packet_snapshot(...)now uses shared context/builderblind_path_override=_blind_packet_path()desloppify/tests/review/policy/test_packet_mode_parity.pyEngineering Outcomes
max_files_per_batch, config redaction, retrospective options) now converges through one path.next_commandshaping.Verification
source .venv/bin/activate && ruff check desloppify/app/commands/review/prepare.py desloppify/app/commands/review/batch/orchestrator.py desloppify/app/commands/review/external.py desloppify/tests/review/policy/test_packet_mode_parity.pysource .venv/bin/activate && pytest -q desloppify/tests/review/review_commands_cases.py desloppify/tests/review/import_scoring/test_review_external.py desloppify/tests/commands/review/test_review_process_guards_direct.py desloppify/tests/review/policy/test_packet_mode_parity.py103 passedTracking
Parent program: #206