Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes existing but previously undiscoverable keyboard shortcuts visible to users by documenting them in the README, exposing the missing configurable “Search Terminals” binding in the Settings UI, and centralizing SSH reconnect shortcut conflict detection so UI messaging and behavior stay consistent.
Changes:
- Add a centralized shortcut inventory module for global shortcut enumeration, SSH reconnect conflict detection, and platform-specific copy/paste labels (with tests).
- Update the Shortcuts Settings tab to render configurable shortcuts via an enum-driven list, add “Search Terminals”, and display a read-only “Built-In Shortcuts” section with contextual availability notes.
- Publish previously undocumented shortcuts in the README (sessions picker, terminal search focus, copy/paste, SSH reconnect) with clarified platform notes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/horizon-ui/src/app/shortcut_inventory.rs | New centralized helpers for shortcut inventory + conflict detection + copy/paste labels, with unit tests. |
| crates/horizon-ui/src/app/settings/shortcuts.rs | Adds editable “Search Terminals” row, refactors editable shortcut rendering, and adds read-only built-in shortcuts section with SSH reconnect availability messaging. |
| crates/horizon-ui/src/app/panels.rs | Replaces duplicated SSH reconnect conflict logic with the centralized helper; removes now-redundant tests. |
| crates/horizon-ui/src/app/mod.rs | Registers the new shortcut_inventory module. |
| README.md | Documents previously missing shortcuts and expands platform-specific notes for copy/paste and contextual SSH reconnect behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search Terminalsbinding to the Settings UI and add a read-only built-in section for contextual shortcutsWhy
Issue #164 called out several shortcuts that already existed in the app but were not published anywhere users would discover them. The audit also found the sessions shortcut was missing from the README table and the settings editor had no row for the configurable search binding.
Validation
cargo fmt --all -- --check./scripts/check-maintainability.shcargo test --workspacecargo clippy --all-targets --all-features -- -D warningscargo clippy --workspace --lib --bins --examples -- -D warnings -D clippy::unwrap_used -D clippy::expect_usedcargo clippy --workspace --all-targets --all-features -- -D warnings -W clippy::pedantictarget/debug/horizonwith an isolatedHOME, opened Settings -> Shortcuts, and captured live screenshots before and after resizing the window during the smoke passCloses #164.