Skip to content

PR#11 improvment proposal#1

Merged
petertheprocess merged 8 commits intopetertheprocess:masterfrom
JasonGantner:master
Jun 30, 2025
Merged

PR#11 improvment proposal#1
petertheprocess merged 8 commits intopetertheprocess:masterfrom
JasonGantner:master

Conversation

@JasonGantner
Copy link
Copy Markdown

@JasonGantner JasonGantner commented Sep 7, 2024

Hello,

I'd like to propose these changes to your artizirk#11 PR.

They include:

  • searching for the config file only when starting wdisplays
  • handling of environment variables to locate the config file
  • replacing nested loops with a single loop and fsm-like conditions
  • reusing HEADS_MAX instead of defining MAX_MONITOR_NUM
  • resolving some minor deprecation warnings in unrelated files
  • renaming some functions to adhere to the implicit naming convention of wd_*

What's still missing (IIRC):

  • a detailed explanation in CHANGELOG.md
  • documentation of the new usable env vars and setting(s)

I plan on forking the main repo to try and maintain wdisplays since it seems abandoned at the moment. I need to delete my current fork in order to do that and start on a sane base.

I'll answer any questions about the proposed changes you'd need me to.

Regards,

PS: I find that the diff is easier to look at with git diff -w --word-diff d5f0e48443c8aac4357cd411b03f143f23df30ac

JasonGantner and others added 8 commits June 2, 2024 16:11
gcc 15 is more strict and compiles C by default with C23.  `noop` is
used as a default null initializer, but now it must have the correct
type, so add a cast.

See also: https://bugs.gentoo.org/946954
@petertheprocess petertheprocess merged commit 4455950 into petertheprocess:master Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants