Update year and translate code tips#67
Conversation
petitlapin
left a comment
petitlapin
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I won't review all the updates now but I suggest instead of translating all comments, to check if they are really needed and only translate them in this case and remove the other ones.
I commented on a few ones that are not useful.
I would also suggest to run codespell (https://github.com/codespell-project/codespell) on the code once the translation has been done, it should allow to fix more typos.
As you may have seen, the project was originally coded ~20 years ago, and the only thing I did on my side to keep it alive is to update it to SDL2 and making it available on android, I didn't spent too much time on it.
| #include "preference.h" | ||
|
|
||
| /*** Variable globales ***/ | ||
| /*** Global varibles ***/ |
| extern int Horloge; | ||
|
|
||
| /*** Constructeur et Destructeur ***/ | ||
| /*** Contructor and Destructor ***/ |
There was a problem hiding this comment.
but for me, we can delete them
| if (Music) { | ||
| PauseMusic(true); | ||
| Mix_HaltMusic(); // Arrete la music | ||
| Mix_HaltMusic(); // Stop music |
There was a problem hiding this comment.
not really useful, the function name is already comprehensive enough
| } | ||
|
|
||
| /*** Joue la music ***/ | ||
| /*** Play music ***/ |
There was a problem hiding this comment.
same, it's just repeating the method name
|
Thanks for feedback :D , but one small note: do you can update copyright to 2026? |
Yes, I'll update it. As long as there are no official release, it's ok if the copyright is still 2025 (and except if there are important issues or improvements, I don't plan to do a version for now) |
2 participants
No description provided.