Feat: Update publish to handle both hash and json string messages#109
Merged
daphnevilhar merged 3 commits intomasterfrom Jul 29, 2025
Merged
Feat: Update publish to handle both hash and json string messages#109daphnevilhar merged 3 commits intomasterfrom
daphnevilhar merged 3 commits intomasterfrom
Conversation
rubendebest
reviewed
Jul 28, 2025
rubendebest
approved these changes
Jul 28, 2025
brunozrk
approved these changes
Jul 29, 2025
Member
brunozrk
left a comment
brunozrk
left a comment
There was a problem hiding this comment.
Nossa, boa!
vai evitar muitos problemas para quem for fazer a migração 😅 👏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Esse PR melhora o método
publish!pra evitar que a mensagem seja transformada em JSON mais de uma vez.Agora, se a mensagem for um hash, ela é convertida com to_json normalmente.
Mas se já for uma string (ou seja, um JSON pronto), ele só envia direto.
Antes podia acontecer de passarmos um JSON como string e ele acabar virando um JSON dentro de outro JSON, o que quebrava a leitura da mensagem no outro lado (ex: SNS, SQS).