Skip to content

Refactor script directory resolution to handle dash-prefixed filenames and add workspace configuration#2

Open
agametis wants to merge 2 commits intopetrowsky:mainfrom
agametis:filenames-starting-with-dash
Open

Refactor script directory resolution to handle dash-prefixed filenames and add workspace configuration#2
agametis wants to merge 2 commits intopetrowsky:mainfrom
agametis:filenames-starting-with-dash

Conversation

@agametis
Copy link

Hello Matt,

cool stuff, what you put together here in this repo. Thanks for sharing.

In my solutions, I use dashes to denote FileMaker script directories like --==== FolderName ====-- and have noticed that the shell scripts cannot handle them correctly.

I have extended the two scripts to properly handle directories and filenames that begin with dashes.

Best Regards, Adam

@petrowsky
Copy link
Owner

I saw the vs code workspace file and was going to ask for it to be removed. Looks like you got that in both requests. Are both of these the same? They look like they both have the folder issue.

@petrowsky
Copy link
Owner

Let's expand the escaping of any characters other than just the dash. My approach would be this. Ask AI for all the possible shell characters that need to be escaped and not just the dash. Then create a single FileMaker file with script names which include any characters that might be invalid in the shell. Then ask an agent to evaluate the fmparse.sh and fmcontext.sh against that output.

@agametis
Copy link
Author

I saw the vs code workspace file and was going to ask for it to be removed. Looks like you got that in both requests. Are both of these the same? They look like they both have the folder issue.

I made the mistake of basing the new branch on the previous one and not on the main branch. That’s why all the files are included in the pull request.

@agametis
Copy link
Author

Let's expand the escaping of any characters other than just the dash. My approach would be this. Ask AI for all the possible shell characters that need to be escaped and not just the dash. Then create a single FileMaker file with script names which include any characters that might be invalid in the shell. Then ask an agent to evaluate the fmparse.sh and fmcontext.sh against that output.

Since all the changed files, are contained in the other pull request, I have committed the improvements in the other pull request, so all the commits are included in the other pull request. I suspect this pull request can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants