Fix hardcoded fmparse.sh path in Explode XML script#6
Open
marcoaperez wants to merge 1 commit intopetrowsky:mainfrom
Open
Fix hardcoded fmparse.sh path in Explode XML script#6marcoaperez wants to merge 1 commit intopetrowsky:mainfrom
marcoaperez wants to merge 1 commit intopetrowsky:mainfrom
Conversation
Replace the hardcoded ~/Desktop/agentic-fm/fmparse.sh path with a dynamic lookup from $$AGENTIC.FM using ConvertFromFileMakerPath. This allows the repo to be cloned anywhere on disk. Also add .venv/ and agent/sandbox/ to .gitignore. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Explode XML companion script has
$fmparsehardcoded to~/Desktop/agentic-fm/fmparse.sh, which requires the repo to live on the Desktop. This PR replaces it with a dynamic lookup from the$$AGENTIC.FMglobal variable that is already set by the Get agentic-fm path script.Before:
After:
This resolves the limitation noted in
filemaker/README.md— the repo can now be cloned anywhere on disk.Changes
filemaker/agentic-fm.xml— Replace hardcoded path withConvertFromFileMakerPath+$$AGENTIC.FMlookupfilemaker/README.md— Update the "Current limitation" note to reflect the fix.gitignore— Addagent/sandbox/and.venv/(both are local working directories that should not be committed)Test plan
~/Documents/GITs/...)fmparse.shresolved via$$AGENTIC.FMagent/xml_parsed/was populated (623 files)agent/context/index files were generated