Collections import compatibility fix for Python versions 3.8+#6
Open
ionite34 wants to merge 1 commit intopettarin:masterfrom
Open
Collections import compatibility fix for Python versions 3.8+#6ionite34 wants to merge 1 commit intopettarin:masterfrom
ionite34 wants to merge 1 commit intopettarin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.7, importing ABCs directly from the collections module shows a
warning and the import is deprecated since Python 3.8+
See:
python/cpython@c66f9f8
Pull request added different compatible import methods per Python version.
Changes for
ipapy/ipastring.py-from collections import MutableSequence import sys if sys.version_info[:2] >= (3, 8): from collections.abc import MutableSequence else: from collections import MutableSequenceChanges for
ipapy/mapper.py-from collections import MutableMapping import sys if sys.version_info[:2] >= (3, 8): from collections.abc import MutableMapping else: from collections import MutableMapping