👌 IMPROVE: add use client directive to support Next.js apps #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineBourin
force-pushed
the
feat/support-nextjs-apps
branch
from
759403c to
7e7d8f2
Compare
|
Validate by me |
KALrious
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made an improvement to add "use client" directive on the top of ScrollSpy component.
This help Next.js users to use and import this component directly from a Server Component.
Rollup by default remove any directive added, so we can add a plugin called rollup-plugin-preserve-directives as described here rollup/rollup#4699.
I've updated the demo-app with the new version. I made some tests on the demo-app without any issues.
Let me know if there is something I missed in the update!