Merged
Conversation
…calls and improve city normalization logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the custom
Scraperclass and related infrastructure, refactoring the codebase to use direct HTTP requests and BeautifulSoup for web scraping instead. It also updates the Decathlon and ThoughtWorks site scrapers to work without the custom scraper and improves location normalization. Additionally, it removes a GitHub Actions workflow and a utility script that are no longer needed.Major refactoring and simplification:
scraper_peviitor.pyfile, which defined the customScraperandRulesclasses, is removed entirely. All sites now use directrequestsandBeautifulSoupcalls for scraping, simplifying the codebase and reducing maintenance overhead.apiUpdateFiles.pyscript, which handled API update calls, is removed as it is no longer used in the workflow..github/workflows/update-Api.ymlis deleted, as it depended on the removed script.Site scraper updates:
sites/decathlon.pyis rewritten to fetch and parse job listings directly usingrequestsandBeautifulSoup, with improved location normalization and city/county mapping logic. The Decathlon logo URL is also updated.sites/thoughtworks.pyis refactored to fetch jobs via direct HTTP requests, removing the dependency on the customScraperclass, and improves handling of missing or malformed location data. [1] [2] [3] [4]